clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-23 12:14:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): upsert property --type on a property

Browse Source 
that has property values makes a graph invalid as property values then
have the wrong types for their property pair. This isn't possible in the
UI because the property type change checks for existing data but the
db-worker-node level does not. This :logseq.property/type update bug was
also possible from plugin/API calls
This commit is contained in:
Gabriel Horner
2026-03-30 17:55:18 -04:00
parent 05fdb7d2ad
commit 8d30cd4a2d
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
deps/outliner/src/logseq/outliner/property.cljs vendored
View File

@@ -221,6 +221,12 @@
{:type :notification
:payload {:message "This property can't change from multiple values to one value because it has existing data."
:type :warning}})))
(when (and (contains? changed-property-attrs :logseq.property/type)
(seq (d/datoms @conn :avet db-ident)))
(throw (ex-info "Disallowed type change with existing data"
{:type :notification
:payload {:message "This property's type can't be changed because it has existing data."
:type :error}})))
(when (seq tx-data)
(ldb/transact! conn tx-data {:outliner-op :update-property
:property-id (:db/id property)}))

14
deps/outliner/test/logseq/outliner/property_test.cljs vendored
View File

@@ -45,6 +45,20 @@
(:block/title (d/entity @conn :user.property/p1-2)))
"3rd property gets unique ident"))))
(deftest upsert-property-rejects-type-change-with-existing-data
(testing "Changing type is rejected when property has values"
(let [conn (db-test/create-conn-with-blocks
[{:page {:block/title "page1"}
:blocks [{:block/title "b1" :build/properties {:status "active"}}]}])]
(is (thrown-with-msg?
js/Error #"Disallowed type change with existing data"
(outliner-property/upsert-property! conn :user.property/status {:logseq.property/type :number} {})))))
(testing "Changing type is allowed when property has no values"
(let [conn (db-test/create-conn-with-blocks {:properties {:empty-prop {:logseq.property/type :default}}})]
(outliner-property/upsert-property! conn :user.property/empty-prop {:logseq.property/type :number} {})
(is (= :number (:logseq.property/type (d/entity @conn :user.property/empty-prop)))))))
(deftest convert-property-input-string
(testing "Convert property input string according to its schema type"
(let [test-uuid (random-uuid)]