clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-27 14:14:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: changing property shouldn't lead to invalid closed values

Browse Source 
To reproduce, create a :default property with two closed values. Change
to url type, the previous closed values would stay on and would be
invalid when selected. Also added a tippy so users are aware that
changing types can alter their existing config
This commit is contained in:
Gabriel Horner
2023-11-30 16:47:02 -05:00
parent 0ffce18d15
commit cfe8d809b8
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/frontend/components/property.cljs
View File

@@ -185,19 +185,27 @@
:interactive true
:disabled false}
(svg/help-circle))]
[:div.col-span-2
[:div.flex.items-center.col-span-2
(ui/select schema-types
(fn [_e v]
(let [type (keyword (string/lower-case v))
update-schema-fn (apply comp
#(assoc % :type type)
;; always delete previous closed values as they
;; are not valid for the new type
#(dissoc % :values)
(keep
(fn [attr]
(when-not (db-property-type/property-type-allows-schema-attribute? type attr)
#(dissoc % attr)))
[:values :position :cardinality :classes]))]
#(dissoc % attr)))
[:cardinality :classes :position]))]
(swap! *property-schema update-schema-fn)
(components-pu/update-property! property @*property-name @*property-schema))))]))]
(components-pu/update-property! property @*property-name @*property-schema))))
(ui/tippy {:html "Changing the property type clears some property configurations."
:class "tippy-hover ml-2"
:interactive true
:disabled false}
(svg/info))]))]
(when (db-property-type/property-type-allows-schema-attribute? (:type @*property-schema) :cardinality)
[:div.grid.grid-cols-4.gap-1.items-center.leading-8