clone/logseq
1
0
Fork 0
mirror of https://github.com/logseq/logseq.git synced 2026-05-20 19:02:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: optimize use-effect for highlighted item handling and cache management

Browse Source
This commit is contained in:
Mega Yu
2026-02-28 22:31:40 +08:00
parent 2e7d22d5ea
commit d3bc5f60c4
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/frontend/components/cmdk/core.cljs
View File

@@ -1057,10 +1057,8 @@
(on-change new-value))))
200)
[])]
;; use-effect [results-ordered input] to check whether the highlighted item is still in the results,
;; if not then clear that puppy out!
;; This was moved to a functional component
(hooks/use-effect! (fn []
(reset! (::all-items-cache state) (vec all-items))
(when highlighted-item
(let [idx (:item-index highlighted-item)
;; Fast path via cached :item-index; fall back to .indexOf if stale.
@@ -1078,11 +1076,11 @@
(.focus el)
(.select el)))
0))]
(load-results :default state)
(fn []
(when timeout-id
(js/clearTimeout timeout-id)))))
[])
(hooks/use-effect! (fn [] (load-results :default state)) [])
;; fired when highlighted item changes (normal keyboard navigation)
(hooks/use-effect!
(fn []
@@ -1278,8 +1276,7 @@
(:group (rum/react (::filter state))))
results-ordered (state->results-ordered state search-mode)
all-items (mapcat last results-ordered)
first-item (first all-items)
_ (reset! (::all-items-cache state) (vec all-items))]
first-item (first all-items)]
[:div.cp__cmdk {:ref #(when-not @(::ref state) (reset! (::ref state) %))
:class (cond-> "w-full h-full relative flex flex-col justify-start"
(not sidebar?) (str " rounded-lg"))}