clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-29 23:40:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#22200)

Browse Source 
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
starr-openai
2026-05-12 17:59:38 -07:00
parent bf623de44b
commit 1165e651fe
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
codex-rs/core/src/unified_exec/process_manager.rs
View File

@@ -398,10 +398,6 @@ impl UnifiedExecProcessManager {
}
Err(err) => {
let failure = match &err {
UnifiedExecError::MissingCommandLine => ToolEventFailure::Rejected {
message: err.to_string(),
applied_patch_delta: None,
},
UnifiedExecError::Rejected { message } => ToolEventFailure::Rejected {
message: message.clone(),
applied_patch_delta: None,

4
codex-rs/core/src/unified_exec/process_manager_tests.rs
View File

@@ -232,7 +232,7 @@ async fn failed_initial_end_for_unstored_process_uses_fallback_output() {
}
#[tokio::test]
async fn startup_rejection_emits_begin_then_declined_end() {
async fn startup_failure_emits_begin_then_failed_end() {
let (session, turn, rx_event) = crate::session::tests::make_session_and_context_with_rx().await;
let context = UnifiedExecContext::new(
Arc::clone(&session),
@@ -295,7 +295,7 @@ async fn startup_rejection_emits_begin_then_declined_end() {
assert_eq!(end_event.call_id, "call-unified-empty");
assert_eq!(
end_event.status,
codex_protocol::protocol::ExecCommandStatus::Declined
codex_protocol::protocol::ExecCommandStatus::Failed
);
}