clone/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-05-23 12:34:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop read and overwrite trait methods

Browse Source
This commit is contained in:
Channing Conger
2026-05-22 21:39:45 -07:00
parent f3509cc0b9
commit 64a9aa24f4
1 changed files with 1 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
codex-rs/code-mode/src/service.rs
View File

@@ -138,15 +138,6 @@ pub trait CodeModeSession: Send + Sync {
fn terminate<'a>(&'a self, cell_id: String) -> CodeModeSessionResultFuture<'a, WaitOutcome>;
fn stored_values<'a>(
&'a self,
) -> Pin<Box<dyn Future<Output = HashMap<String, JsonValue>> + Send + 'a>>;
fn replace_stored_values<'a>(
&'a self,
values: HashMap<String, JsonValue>,
) -> Pin<Box<dyn Future<Output = ()> + Send + 'a>>;
fn shutdown<'a>(&'a self) -> CodeModeSessionResultFuture<'a, ()>;
}
@@ -213,14 +204,6 @@ impl CodeModeService {
}
}
async fn stored_values(&self) -> HashMap<String, JsonValue> {
self.inner.stored_values.lock().await.clone()
}
pub async fn replace_stored_values(&self, values: HashMap<String, JsonValue>) {
*self.inner.stored_values.lock().await = values;
}
fn allocate_cell_id(&self) -> CellId {
CellId(
self.inner
@@ -283,7 +266,7 @@ impl CodeModeService {
let cell_id_text = cell_id.to_string();
let (event_tx, event_rx) = mpsc::unbounded_channel();
let (control_tx, control_rx) = mpsc::unbounded_channel();
let stored_values = self.stored_values().await;
let stored_values = self.inner.stored_values.lock().await.clone();
let cancellation_token = CancellationToken::new();
let (runtime_tx, runtime_control_tx, runtime_terminate_handle) = {
let mut sessions = self.inner.sessions.lock().await;
@@ -469,19 +452,6 @@ impl CodeModeSession for CodeModeService {
Box::pin(CodeModeService::terminate(self, cell_id))
}
fn stored_values<'a>(
&'a self,
) -> Pin<Box<dyn Future<Output = HashMap<String, JsonValue>> + Send + 'a>> {
Box::pin(CodeModeService::stored_values(self))
}
fn replace_stored_values<'a>(
&'a self,
values: HashMap<String, JsonValue>,
) -> Pin<Box<dyn Future<Output = ()> + Send + 'a>> {
Box::pin(CodeModeService::replace_stored_values(self, values))
}
fn shutdown<'a>(&'a self) -> CodeModeSessionResultFuture<'a, ()> {
Box::pin(CodeModeService::shutdown(self))
}